Remove redundant cast in _AggregateMatrices#295
Merged
ValerianRey merged 2 commits intomainfrom Apr 4, 2025
Merged
Conversation
ValerianRey
added
package: autojac
cc: refactor
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
ValerianRey
changed the title
_AggregateMatrices
PierreQuinton
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the type of
key_orderis alreadyOrderedSet, there is no point in casting it toOrderedSet. This PR removes this cast to simply use the providedkey_orderin the constructor of_AggregateMatrices. I also verified that all actual calls to this constructor use akey_orderthat is of typeOrderedSet, and it's the case already. This should thus not change anything.